From d8036fea2f407ed63fd9b20516e37df47e4f6db2 Mon Sep 17 00:00:00 2001
From: Alexander Minges <alexander.minges@uni-due.de>
Date: Thu, 10 Jul 2025 15:13:39 +0200
Subject: [PATCH] fix: Improve JATS list tag conversion with sequential
 processing

Refactored list tag conversion to handle ordered and unordered lists more robustly. Uses regex for
closing ordered list tags to prevent duplicate key issues and ensures proper tag replacement.
---
 doi2dataset.py | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/doi2dataset.py b/doi2dataset.py
index 6d5d694..7d23409 100755
--- a/doi2dataset.py
+++ b/doi2dataset.py
@@ -866,6 +866,23 @@ class AbstractProcessor:
         if not text:
             return ""
 
+        # Handle list tags with sequential processing to avoid duplicate keys
+        # Process ordered lists first - replace both opening and closing tags
+        text = text.replace('<jats:list list-type="order">', "<ol>")
+        # Find and replace closing tags for ordered lists
+        import re
+
+        # Replace closing tags that follow ordered list openings
+        # This regex matches </jats:list> that comes after <ol> tags
+        pattern = r'(<ol>.*?)</jats:list>'
+        text = re.sub(pattern, r'\1</ol>', text, flags=re.DOTALL)
+
+        # Process unordered lists second
+        text = text.replace('<jats:list list-type="bullet">', "<ul>")
+        # Replace remaining </jats:list> tags as unordered list closings
+        text = text.replace('</jats:list>', '</ul>')
+
+        # Handle other JATS tags
         replacements = {
             "<jats:italic>": "<i>",
             "</jats:italic>": "</i>",
@@ -885,10 +902,6 @@ class AbstractProcessor:
             "</jats:p>": "</p>",
             "<jats:title>": "<h2>",
             "</jats:title>": "</h2>",
-            '<jats:list list-type="bullet">': "<ul>",
-            "</jats:list>": "</ul>",
-            '<jats:list list-type="order">': "<ol>",
-            "</jats:list>": "</ol>",
             "<jats:list-item>": "<li>",
             "</jats:list-item>": "</li>",
             "<jats:blockquote>": "<blockquote>",