Implement swapping edge case, restructure sources.
This commit is contained in:
Oliver Rümpelein
parent
3f6f9f795f
commit
55beeb92c9
5 changed files with 173 additions and 76 deletions
326
spec/support/ds4rolls/executor.spec.ts
Normal file
326
spec/support/ds4rolls/executor.spec.ts
Normal file
|
|
@ -0,0 +1,326 @@
|
|||
import { rollCheckMultipleDice, rollCheckSingleDie } from "../../../src/module/rolls/roll-executor";
|
||||
import { RollProvider } from "../../../src/module/rolls/roll-provider";
|
||||
|
||||
import "jasmine";
|
||||
import { RollResult, RollResultStatus } from "../../../src/module/rolls/roll-data";
|
||||
|
||||
function mockSingleThrow(value: number): RollProvider {
|
||||
const rollProvider = jasmine.createSpyObj("rollProvider", ["getNextRoll"]);
|
||||
rollProvider.getNextRoll = jasmine.createSpy("getNextRoll").and.returnValue(value);
|
||||
return rollProvider;
|
||||
}
|
||||
|
||||
function mockMultipleThrows(values: Array<number>): RollProvider {
|
||||
const rollProvider = jasmine.createSpyObj("rollProvider", ["getNextRolls"]);
|
||||
rollProvider.getNextRolls = jasmine.createSpy("getNextRolls").and.returnValue(values);
|
||||
return rollProvider;
|
||||
}
|
||||
|
||||
describe("DS4 Rolls with one die and no modifications.", () => {
|
||||
it("Should do a regular success roll.", () => {
|
||||
const rollProvider = mockSingleThrow(4);
|
||||
|
||||
expect(rollCheckSingleDie(12, {}, rollProvider)).toEqual(new RollResult(4, RollResultStatus.SUCCESS, [4]));
|
||||
});
|
||||
|
||||
it("Should do a single success roll on success upper edge case.", () => {
|
||||
const rollProvider = mockSingleThrow(4);
|
||||
|
||||
expect(rollCheckSingleDie(4, {}, rollProvider)).toEqual(new RollResult(4, RollResultStatus.SUCCESS, [4]));
|
||||
});
|
||||
|
||||
it("Should do a single failure roll on lower edge case.", () => {
|
||||
const rollProvider = mockSingleThrow(5);
|
||||
|
||||
expect(rollCheckSingleDie(4, {}, rollProvider)).toEqual(new RollResult(0, RollResultStatus.FAILURE, [5]));
|
||||
});
|
||||
|
||||
it("Should do a single failure roll on upper edge case '19'.", () => {
|
||||
const rollProvider = mockSingleThrow(19);
|
||||
|
||||
expect(rollCheckSingleDie(4, {}, rollProvider)).toEqual(new RollResult(0, RollResultStatus.FAILURE, [19]));
|
||||
});
|
||||
|
||||
it("Should do a single crit success roll on '1'.", () => {
|
||||
const rollProvider = mockSingleThrow(1);
|
||||
|
||||
expect(rollCheckSingleDie(4, {}, rollProvider)).toEqual(
|
||||
new RollResult(4, RollResultStatus.CRITICAL_SUCCESS, [1]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a single crit failure roll on '20'.", () => {
|
||||
const rollProvider = mockSingleThrow(20);
|
||||
|
||||
expect(rollCheckSingleDie(4, {}, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.CRITICAL_FAILURE, [20]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("DS4 Rolls with one die and slaying dice, first throw.", () => {
|
||||
it("Should do a crit success on `1`", () => {
|
||||
const rollProvider = mockSingleThrow(1);
|
||||
|
||||
expect(rollCheckSingleDie(4, { useSlayingDice: true }, rollProvider)).toEqual(
|
||||
new RollResult(4, RollResultStatus.CRITICAL_SUCCESS, [1]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a crit fail on `20`", () => {
|
||||
const rollProvider = mockSingleThrow(20);
|
||||
|
||||
expect(rollCheckSingleDie(4, { useSlayingDice: true }, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.CRITICAL_FAILURE, [20]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("DS4 Rolls with one die and slaying dice, followup throw.", () => {
|
||||
it("Should do a crit success on `1`", () => {
|
||||
const rollProvider = mockSingleThrow(1);
|
||||
|
||||
expect(rollCheckSingleDie(4, { useSlayingDice: true, slayingDiceRepetition: true }, rollProvider)).toEqual(
|
||||
new RollResult(4, RollResultStatus.CRITICAL_SUCCESS, [1]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a regular fail on `20`", () => {
|
||||
const rollProvider = mockSingleThrow(20);
|
||||
|
||||
expect(rollCheckSingleDie(4, { useSlayingDice: true, slayingDiceRepetition: true }, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.FAILURE, [20]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a regular success on `20` with a test value of 20", () => {
|
||||
const rollProvider = mockSingleThrow(20);
|
||||
|
||||
expect(rollCheckSingleDie(20, { useSlayingDice: true, slayingDiceRepetition: true }, rollProvider)).toEqual(
|
||||
new RollResult(20, RollResultStatus.SUCCESS, [20]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("DS4 Rolls with one die and crit roll modifications.", () => {
|
||||
it("Should do a crit success on `1`.", () => {
|
||||
const rollProvider = mockSingleThrow(1);
|
||||
|
||||
expect(rollCheckSingleDie(4, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(4, RollResultStatus.CRITICAL_SUCCESS, [1]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a crit success on `maxCritSucc`.", () => {
|
||||
const rollProvider = mockSingleThrow(2);
|
||||
|
||||
expect(rollCheckSingleDie(4, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(4, RollResultStatus.CRITICAL_SUCCESS, [2]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a success on lower edge case `3`.", () => {
|
||||
const rollProvider = mockSingleThrow(3);
|
||||
|
||||
expect(rollCheckSingleDie(4, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(3, RollResultStatus.SUCCESS, [3]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a success on upper edge case `18`.", () => {
|
||||
const rollProvider = mockSingleThrow(18);
|
||||
|
||||
expect(rollCheckSingleDie(4, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.FAILURE, [18]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a crit fail on `minCritFail`.", () => {
|
||||
const rollProvider = mockSingleThrow(19);
|
||||
|
||||
expect(rollCheckSingleDie(4, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.CRITICAL_FAILURE, [19]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should do a crit fail on `20`", () => {
|
||||
const rollProvider = mockSingleThrow(20);
|
||||
|
||||
expect(rollCheckSingleDie(4, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.CRITICAL_FAILURE, [20]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("DS4 Rolls with multiple dice and no modifiers.", () => {
|
||||
it("Should do a crit fail on `20` for first roll.", () => {
|
||||
const rollProvider = mockMultipleThrows([20, 15, 6]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, {}, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.CRITICAL_FAILURE, [20, 15, 6]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed normally with all rolls crit successes.", () => {
|
||||
const rollProvider = mockMultipleThrows([1, 1, 1]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, {}, rollProvider)).toEqual(
|
||||
new RollResult(48, RollResultStatus.SUCCESS, [1, 1, 1]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed with the last roll not being suficient.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 15, 15]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, {}, rollProvider)).toEqual(
|
||||
new RollResult(30, RollResultStatus.SUCCESS, [15, 15, 15]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed with the last roll a crit success.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 15, 1]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, {}, rollProvider)).toEqual(
|
||||
new RollResult(38, RollResultStatus.SUCCESS, [15, 15, 1]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed with the last roll being 20 and one crit success.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 1, 20]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, {}, rollProvider)).toEqual(
|
||||
new RollResult(43, RollResultStatus.SUCCESS, [20, 15, 1]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should properly maximize throw result with all dice success.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 4, 12]);
|
||||
|
||||
expect(rollCheckMultipleDice(46, {}, rollProvider)).toEqual(
|
||||
new RollResult(31, RollResultStatus.SUCCESS, [15, 12, 4]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should properly maximize throw result with one dice a failure.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 8, 20]);
|
||||
|
||||
expect(rollCheckMultipleDice(46, {}, rollProvider)).toEqual(
|
||||
new RollResult(35, RollResultStatus.SUCCESS, [20, 15, 8]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should maximize on 'lowest dice higher than last test and crit success thrown'-Edge case, no change required.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 1, 8]);
|
||||
|
||||
expect(rollCheckMultipleDice(46, {}, rollProvider)).toEqual(
|
||||
new RollResult(35, RollResultStatus.SUCCESS, [1, 15, 8]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should maximize on 2-dice 'lowest dice higher than last test and crit success thrown'-Edge case, no change required.", () => {
|
||||
const rollProvider = mockMultipleThrows([1, 8]);
|
||||
|
||||
expect(rollCheckMultipleDice(24, {}, rollProvider)).toEqual(
|
||||
new RollResult(20, RollResultStatus.SUCCESS, [1, 8]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should maximize on 2-dice 'lowest dice higher than last test and crit success thrown'-Edge case, change required.", () => {
|
||||
const rollProvider = mockMultipleThrows([1, 19]);
|
||||
|
||||
expect(rollCheckMultipleDice(38, {}, rollProvider)).toEqual(
|
||||
new RollResult(37, RollResultStatus.SUCCESS, [19, 1]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("DS4 Rolls with multiple dice and min/max modifiers.", () => {
|
||||
it("Should do a crit fail on `19` for first roll.", () => {
|
||||
const rollProvider = mockMultipleThrows([19, 15, 6]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.CRITICAL_FAILURE, [19, 15, 6]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed with all rolls crit successes (1 and 2).", () => {
|
||||
const rollProvider = mockMultipleThrows([2, 1, 2]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(48, RollResultStatus.SUCCESS, [2, 2, 1]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed with the last roll not being suficient.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 15, 15]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(30, RollResultStatus.SUCCESS, [15, 15, 15]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed with the last roll a crit success `2`.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 15, 2]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(38, RollResultStatus.SUCCESS, [15, 15, 2]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed with the last roll being `20` and one crit success '2'.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 2, 20]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(43, RollResultStatus.SUCCESS, [20, 15, 2]),
|
||||
);
|
||||
});
|
||||
|
||||
it("Should succeed with the last roll being `19` and one crit success '2'.", () => {
|
||||
const rollProvider = mockMultipleThrows([15, 2, 19]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, { maxCritSucc: 2, minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(42, RollResultStatus.SUCCESS, [19, 15, 2]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("DS4 Rolls with multiple dice and fail modifiers.", () => {
|
||||
it("Should do a crit fail on `19` for first roll.", () => {
|
||||
const rollProvider = mockMultipleThrows([19, 15, 6]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, { minCritFail: 19 }, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.CRITICAL_FAILURE, [19, 15, 6]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("DS4 Rolls with multiple dice and success modifiers.", () => {
|
||||
it("Should succeed with all rolls crit successes (1 and 2).", () => {
|
||||
const rollProvider = mockMultipleThrows([2, 1, 2]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, { maxCritSucc: 2 }, rollProvider)).toEqual(
|
||||
new RollResult(48, RollResultStatus.SUCCESS, [2, 2, 1]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe("DS4 Rolls with multiple and slaying dice, first throw", () => {
|
||||
it("Should fail with the first roll being a `20`", () => {
|
||||
const rollProvider = mockMultipleThrows([20, 2, 19]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, {}, rollProvider)).toEqual(
|
||||
new RollResult(0, RollResultStatus.CRITICAL_FAILURE, [20, 2, 19]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
// TODO: Implement & reactivate
|
||||
xdescribe("DS4 Rolls with multiple and slaying dice, recurrent throw", () => {
|
||||
it("Should regularly succeed with the first roll being a `20`", () => {
|
||||
const rollProvider = mockMultipleThrows([20, 2, 19]);
|
||||
|
||||
expect(rollCheckMultipleDice(48, {}, rollProvider)).toEqual(
|
||||
new RollResult(40, RollResultStatus.CRITICAL_FAILURE, [20, 2, 19]),
|
||||
);
|
||||
});
|
||||
});
|
||||
24
spec/support/ds4rolls/utils.spec.ts
Normal file
24
spec/support/ds4rolls/utils.spec.ts
Normal file
|
|
@ -0,0 +1,24 @@
|
|||
import "jasmine";
|
||||
import { isDiceSwapNecessary } from "../../../src/module/rolls/roll-utils";
|
||||
|
||||
describe("Utility function testing if dice swap is necessery", () => {
|
||||
it("Should not swap if all dice are crit successes.", () => {
|
||||
expect(isDiceSwapNecessary([1, 1, 1], [], 9)).toBeFalse();
|
||||
});
|
||||
|
||||
it("Should not swap if no die is crit success.", () => {
|
||||
expect(isDiceSwapNecessary([], [2, 2, 2], 9)).toBeFalse();
|
||||
});
|
||||
|
||||
it("Should not swap if all dice are already in use", () => {
|
||||
expect(isDiceSwapNecessary([1], [9, 8], 10)).toBeFalse();
|
||||
});
|
||||
|
||||
it("Should not swap if result does not get any better", () => {
|
||||
expect(isDiceSwapNecessary([1], [8], 4)).toBeFalse();
|
||||
});
|
||||
|
||||
it("Should swap if result does get better", () => {
|
||||
expect(isDiceSwapNecessary([1], [19], 18)).toBeTrue();
|
||||
});
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue