From fc3f3eb1f35ad96c6e21b20d5ef42ea282fc288f Mon Sep 17 00:00:00 2001
From: Johannes Loher <johannes.loher@fg4f.de>
Date: Mon, 8 Feb 2021 02:15:43 +0100
Subject: [PATCH] Simplify DS4Check.MODIFIERS

---
 src/module/rolls/check.ts | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/module/rolls/check.ts b/src/module/rolls/check.ts
index 12216ae..0ff4ef0 100644
--- a/src/module/rolls/check.ts
+++ b/src/module/rolls/check.ts
@@ -93,11 +93,6 @@ export class DS4Check extends DiceTerm {
         }
     }
 
-    /** Term Modifiers */
-    noop(): void {
-        return;
-    }
-
     // DS4 only allows recursive explosions
     explode(modifier: string): void {
         const rgx = /[xX]/;
@@ -135,7 +130,7 @@ export class DS4Check extends DiceTerm {
     static DENOMINATION = "s";
     static MODIFIERS = {
         x: "explode",
-        c: "noop", // Modifier is consumed in constructor for target value
-        v: "noop", // Modifier is consumed in constructor for target value
+        c: (): void => undefined, // Modifier is consumed in constructor for crit
+        v: (): void => undefined, // Modifier is consumed in constructor for target value
     };
 }