Athemis/ds4
1
0
Fork 0
Code Issues 8 Pull requests 3 Projects Releases 9 Packages 1 Wiki Activity

perf(consume): skip eager description enrichment #130

Merged
Athemis merged 1 commit from perf/lazy-consume-description into main 2026-03-16 09:01:10 +00:00
Conversation 0 Commits 1 Files changed 2 +35 -1
Athemis commented 2026-03-15 22:17:26 +00:00
Owner
Copy link

Summary

  • skip item description enrichment on the fast consume path when no consume dialog will be shown
  • keep dialog-based consume flows unchanged by only enriching descriptions when prompt content is needed
  • add a regression test covering self-targeted consume effects without dialog options

Test Plan

  • pnpm test:vitest spec/apps/actor/consume-flow.spec.ts

Reopens accidentally closed #124

## Summary - skip item description enrichment on the fast consume path when no consume dialog will be shown - keep dialog-based consume flows unchanged by only enriching descriptions when prompt content is needed - add a regression test covering self-targeted consume effects without dialog options ## Test Plan - `pnpm test:vitest spec/apps/actor/consume-flow.spec.ts` Reopens accidentally closed #124
perf(consume): skip eager description enrichment
All checks were successful
renovate/stability-days Not a Renovate PR - check skipped
ci/woodpecker/pr/auto-approve-renovate-checks Pipeline was successful
Details
ci/woodpecker/pr/checks Pipeline was successful
Details
90e5b56563
Merge branch 'main' into perf/lazy-consume-description
All checks were successful
renovate/stability-days Not a Renovate PR - check skipped
ci/woodpecker/pr/auto-approve-renovate-checks Pipeline was successful
Details
ci/woodpecker/pr/checks Pipeline was successful
Details
9e782e397b
Athemis force-pushed perf/lazy-consume-description from 9e782e397b
All checks were successful
renovate/stability-days Not a Renovate PR - check skipped
ci/woodpecker/pr/auto-approve-renovate-checks Pipeline was successful
Details
ci/woodpecker/pr/checks Pipeline was successful
Details
to 92baa0efef
All checks were successful
renovate/stability-days Not a Renovate PR - check skipped
ci/woodpecker/pr/auto-approve-renovate-checks Pipeline was successful
Details
ci/woodpecker/pr/checks Pipeline was successful
Details
2026-03-16 09:00:04 +00:00 Compare
Athemis deleted branch perf/lazy-consume-description 2026-03-16 09:01:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
technical-debt

Technical improvements needed to maintain code quality and future compatibility

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
technical-debt
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Athemis/ds4!130
No description provided.