perf: avoid eager description enrichment in fast consume flow #123

New issue

Open

opened 2026-03-15 17:56:27 +00:00 by Athemis · 0 comments

Athemis commented

2026-03-15 17:56:27 +00:00

Owner

Expected Behavior

Self-targeted consume effects without target or formula prompts should execute the fast consume path without enriching the item description first. Description enrichment should only happen when the consume flow actually needs dialog content.

Current Behavior

The consume flow eagerly calls description enrichment even when the effect is self-targeted and no dialog is shown. That adds avoidable rich-text processing overhead to the common consume path.

Steps to Reproduce

Open src/apps/actor/consume-flow.js on main.
Follow the onConsumeItem() path for a self-targeted consume effect without allowTargetChange, allowFormulaChange, or prompt target mode.
Observe that enrichItemDescription(item) is called before effect execution even though no dialog content is needed.
Add a regression test and run pnpm test:vitest spec/apps/actor/consume-flow.spec.ts.

Context

This was found during a performance review of the newer consume-item flow. The cost is moderate rather than catastrophic, but it sits on a high-frequency path and is easy to avoid safely.

Version

main @ 4df70e90

Foundry VTT Version

Not runtime-specific; identified in the current source path during automated tests.

Operating System

Linux

Browser / App

Other

Relevant Modules

None.

### Expected Behavior Self-targeted consume effects without target or formula prompts should execute the fast consume path without enriching the item description first. Description enrichment should only happen when the consume flow actually needs dialog content. ### Current Behavior The consume flow eagerly calls description enrichment even when the effect is self-targeted and no dialog is shown. That adds avoidable rich-text processing overhead to the common consume path. ### Steps to Reproduce 1. Open `src/apps/actor/consume-flow.js` on `main`. 2. Follow the `onConsumeItem()` path for a self-targeted consume effect without `allowTargetChange`, `allowFormulaChange`, or `prompt` target mode. 3. Observe that `enrichItemDescription(item)` is called before effect execution even though no dialog content is needed. 4. Add a regression test and run `pnpm test:vitest spec/apps/actor/consume-flow.spec.ts`. ### Context This was found during a performance review of the newer consume-item flow. The cost is moderate rather than catastrophic, but it sits on a high-frequency path and is easy to avoid safely. ### Version main @ 4df70e90 ### Foundry VTT Version Not runtime-specific; identified in the current source path during automated tests. ### Operating System Linux ### Browser / App Other ### Relevant Modules None.