Athemis/ds4
1
0
Fork 0
Code Issues 8 Pull requests 3 Projects Releases 9 Packages 1 Wiki Activity

perf(consume): skip eager description enrichment #124

Closed
Athemis wants to merge 1 commit from perf/lazy-consume-description into main
pull from: perf/lazy-consume-description
merge into: Athemis:main
Conversation 0 Commits 1 Files changed 2 +35 -1
Athemis commented 2026-03-15 17:56:40 +00:00
Owner
Copy link

Summary

  • skip item description enrichment on the fast consume path when no consume dialog will be shown
  • keep dialog-based consume flows unchanged by only enriching descriptions when prompt content is needed
  • add a regression test covering self-targeted consume effects without dialog options

Test Plan

  • pnpm test:vitest spec/apps/actor/consume-flow.spec.ts

Closes #123

## Summary - skip item description enrichment on the fast consume path when no consume dialog will be shown - keep dialog-based consume flows unchanged by only enriching descriptions when prompt content is needed - add a regression test covering self-targeted consume effects without dialog options ## Test Plan - `pnpm test:vitest spec/apps/actor/consume-flow.spec.ts` Closes #123
perf(consume): skip eager description enrichment
All checks were successful
renovate/stability-days Not a Renovate PR - check skipped
ci/woodpecker/pr/auto-approve-renovate-checks Pipeline was successful
Details
ci/woodpecker/pr/checks Pipeline was successful
Details
90e5b56563
Athemis closed this pull request 2026-03-15 20:45:50 +00:00
All checks were successful
renovate/stability-days Not a Renovate PR - check skipped
Required
ci/woodpecker/pr/auto-approve-renovate-checks Pipeline was successful
Details
ci/woodpecker/pr/checks Pipeline was successful
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
technical-debt

Technical improvements needed to maintain code quality and future compatibility

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
technical-debt
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Athemis/ds4!124
No description provided.