refactor(actor): separate consume flow UI rendering #108

Merged

Athemis merged 12 commits from refactor/consume-flow-ui-separation into main 2026-03-06 17:59:14 +00:00

Conversation 0 Commits 12 Files changed 7 +987 -176

Athemis commented 2026-03-06 17:43:50 +00:00

Owner

Copy link

Summary

• extract consume-flow UI rendering into a dedicated renderer module and move dialog/chat markup to Handlebars templates
• preserve existing consume behavior with inline fallback renderers for missing or failing template runtime paths
• strengthen regression coverage for chat/dialog semantics, real template rendering, and fallback/error-handling paths

Verification

• pnpm vitest run spec/apps/actor/consume-flow.spec.ts spec/apps/actor/inventory-consumables-regressions.spec.ts spec/hooks/pre-update-item.spec.ts spec/hooks/effect-expiry.spec.ts spec/apps/item/consume-properties-template.spec.ts
• pnpm test:typecheck
• pnpm lint (fails only due unrelated files under .worktrees/feature-spell-talent-automation/... being linted by the workspace root ESLint command)

## Summary - extract consume-flow UI rendering into a dedicated renderer module and move dialog/chat markup to Handlebars templates - preserve existing consume behavior with inline fallback renderers for missing or failing template runtime paths - strengthen regression coverage for chat/dialog semantics, real template rendering, and fallback/error-handling paths ## Verification - `pnpm vitest run spec/apps/actor/consume-flow.spec.ts spec/apps/actor/inventory-consumables-regressions.spec.ts spec/hooks/pre-update-item.spec.ts spec/hooks/effect-expiry.spec.ts spec/apps/item/consume-properties-template.spec.ts` - `pnpm test:typecheck` - `pnpm lint` *(fails only due unrelated files under `.worktrees/feature-spell-talent-automation/...` being linted by the workspace root ESLint command)*

Athemis added 11 commits 2026-03-06 17:43:51 +00:00

test(consume): strengthen chat/dialog behavior characterization e14e21e8e3

test(consume): harden consume summary assertions 5d2c54df81

refactor(actor): extract consume flow UI renderer module d103244498

refactor(actor): render consume effect dialog via template 59f46df8c9

fix(actor): guard consume dialog template render and test template path 8cfe4d61d7

refactor(actor): template no-combat consume confirmation c984bed7d1

fix(actor): guard no-combat confirm template fallback c2d5562d70

refactor(actor): render consume chat summary via template f0f04d5378

test(actor): exercise consume summary template and fallback paths eef809a3cf

refactor(actor): clean consume inline markup remnants 3038ce39f5

fix(consume): fallback dialog template render failures d764278df3

Athemis added 1 commit 2026-03-06 17:49:23 +00:00

Merge origin/main into refactor/consume-flow-ui-separation bf9aeb7bc6

Athemis merged commit 6128e3082f into main 2026-03-06 17:59:14 +00:00

Athemis referenced this pull request from a commit 2026-03-06 17:59:14 +00:00

Merge pull request 'refactor(actor): separate consume flow UI rendering' (#108) from refactor/consume-flow-ui-separation into main

Athemis added this to the 3.3.0 milestone 2026-03-06 18:04:29 +00:00

Athemis added the

technical-debt

label 2026-03-06 18:04:35 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

technical-debt

Technical improvements needed to maintain code quality and future compatibility

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

question

technical-debt

wontfix

Milestone

Clear milestone

No items

No milestone

3.3.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Athemis/ds4!108

No description provided.