Athemis/ds4
1
0
Fork 0
Code Issues 2 Pull requests 3 Projects Releases 9 Packages 1 Wiki Activity

WIP: feat!: migrate remaining JavaScript files to TypeScript #33

Draft
Athemis wants to merge 4 commits from typescript-conversion into main
pull from: typescript-conversion
merge into: Athemis:main
Conversation 0 Commits 4 Files changed 68 +3399 -1723
Athemis commented 2025-12-07 12:28:15 +00:00
Owner
Copy link

Complete the TypeScript migration by converting all remaining .js files
in src/ to .ts, restoring full type safety after the temporary JS fallback
that was necessary due to missing Foundry V10+ type definitions.

This migration was enabled by the now-available foundry-vtt-types for V13,
allowing us to return to the type-safe codebase that existed prior to the
V10 migration.

Changes:

  • Convert all remaining .js files to .ts (69 files changed)
  • Add type definition files (src/types/*.d.ts) for Foundry globals

This restores the type safety quality from commit a94ec3e3e8 (Nov 2022, Foundry V9)
adapted for Foundry V13 API and type definitions.

Complete the TypeScript migration by converting all remaining .js files in src/ to .ts, restoring full type safety after the temporary JS fallback that was necessary due to missing Foundry V10+ type definitions. This migration was enabled by the now-available foundry-vtt-types for V13, allowing us to return to the type-safe codebase that existed prior to the V10 migration. Changes: - Convert all remaining .js files to .ts (69 files changed) - Add type definition files (src/types/*.d.ts) for Foundry globals This restores the type safety quality from commit a94ec3e3e8 (Nov 2022, Foundry V9) adapted for Foundry V13 API and type definitions.
feat!: migrate remaining JavaScript files to TypeScript
Some checks failed
ci/woodpecker/pr/checks Pipeline failed
Details
d5f68fc5a8
 
Complete the TypeScript migration by converting all remaining .js files
in src/ to .ts, restoring full type safety after the temporary JS fallback
that was necessary due to missing Foundry V10+ type definitions.

This migration was enabled by the now-available foundry-vtt-types for V13,
allowing us to return to the type-safe codebase that existed prior to the
V10 migration.

Changes:
- Convert all remaining .js files to .ts (69 files changed)
- Add type definition files (src/types/*.d.ts) for Foundry globals

This restores the type safety quality from commit a94ec3e3e8 (Nov 2022, Foundry V9)
adapted for Foundry V13 API and type definitions.
chore: add SPDX license identifiers to source files
All checks were successful
ci/woodpecker/pr/checks Pipeline was successful
Details
efacb34c2e
fix: highlight slaying dice correctly
All checks were successful
ci/woodpecker/pr/checks Pipeline was successful
Details
d7ff0e86d3
 
- change property name from _dice to dice in DS4Roll class
chore: move Number.isNumeric declaration to a dedicated file
All checks were successful
ci/woodpecker/pr/checks Pipeline was successful
Details
46b76ff7e4
Athemis changed title from feat!: migrate remaining JavaScript files to TypeScript to WIP: feat!: migrate remaining JavaScript files to TypeScript 2025-12-08 07:09:34 +00:00
Athemis changed target branch from v13-appv2 to main 2025-12-15 14:02:28 +00:00
Athemis changed target branch from main to chore/release-3.2.1 2025-12-15 14:02:37 +00:00
Athemis changed target branch from chore/release-3.2.1 to main 2025-12-15 14:02:47 +00:00
All checks were successful
ci/woodpecker/pr/checks Pipeline was successful
Required
Details
This pull request has changes conflicting with the target branch.
  • eslint.config.js
  • package.json
  • pnpm-lock.yaml
  • src/apps/actor/base-sheet.ts
  • src/apps/ruler/token-ruler.ts
  • src/migration/migration.js
  • tsconfig.json
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin typescript-conversion:typescript-conversion
git switch typescript-conversion
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
technical-debt

Technical improvements needed to maintain code quality and future compatibility

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
technical-debt
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Athemis/ds4!33
No description provided.