WIP: feat: allow humanoid creatures to own talents #48

Draft

Athemis wants to merge 4 commits from feat/talents-for-humanoid-creatures into main

Athemis commented

2025-12-15 17:04:32 +00:00

Owner

Some creatures in e.g. the Caera campaign box have both special creature
abilities and talents which were formerly reserved for player
characters. Allow those for at least humanoid creatures.

This may be extended in the future by adding other creature types to the
allow list.

Some creatures in e.g. the Caera campaign box have both special creature abilities and talents which were formerly reserved for player characters. Allow those for at least humanoid creatures. This may be extended in the future by adding other creature types to the allow list.

Athemis added 1 commit

2025-12-15 17:04:32 +00:00

feat: allow humanoid creatures to own talents

ci/woodpecker/pr/checks Pipeline was successful

Details

8d530b0d29

Some creatures in e.g. the Caera campaign box have both special creature
abilities and talents which were formerly reserved for player
characters. Allow those for at least humanoid creatures.

This may be extended in the future by adding other creature types to the
allow list.

Athemis added 1 commit

2025-12-15 17:45:32 +00:00

test: centralize foundry globals stubs and add creature talent specs

ci/woodpecker/pr/checks Pipeline was successful

Details

2e3a8a8d93

Athemis added 1 commit

2025-12-15 18:07:43 +00:00

Merge branch 'main' into feat/talents-for-humanoid-creatures

ci/woodpecker/pr/checks Pipeline was successful

Details

d055c468e6

Athemis commented

2026-02-05 18:30:40 +00:00

Author

Owner

@claw-bot review

claw-bot commented

2026-02-06 07:22:13 +00:00

First-time contributor

Quick review

Summary:

✅ Change is nicely scoped: allow talents for eligible creature types + keeps existing creature abilities intact.
✅ Good test coverage: ownable item types + hook behavior (humanoid allowed, others rejected).
✅ CI is green.

Notes / suggestions:

UI vs logic drift: the sheet template checks creatureType == "humanoid", while the TS logic uses TALENT_ELIGIBLE_CREATURE_TYPES. If you later extend the allow-list, the UI could lag behind. Consider basing the UI condition on the same source of truth (or at least also show the section when itemsByType.talent is non-empty).
Existing data edge-case: if a non-humanoid creature already has talent items (old data), the current UI will hide them entirely, making cleanup awkward. A read-only display (but no add button) would avoid that.
i18n keys: please double-check that DS4.SortByTalentRank / DS4.TalentRank (etc.) exist in the lang files.

No blockers from me. Once this is undrafted, it looks mergeable.

**Quick review** Summary: - ✅ Change is nicely scoped: allow talents for eligible creature types + keeps existing creature abilities intact. - ✅ Good test coverage: ownable item types + hook behavior (humanoid allowed, others rejected). - ✅ CI is green. Notes / suggestions: - **UI vs logic drift**: the sheet template checks `creatureType == "humanoid"`, while the TS logic uses `TALENT_ELIGIBLE_CREATURE_TYPES`. If you later extend the allow-list, the UI could lag behind. Consider basing the UI condition on the same source of truth (or at least also show the section when `itemsByType.talent` is non-empty). - **Existing data edge-case**: if a non-humanoid creature already has talent items (old data), the current UI will hide them entirely, making cleanup awkward. A read-only display (but no add button) would avoid that. - **i18n keys**: please double-check that `DS4.SortByTalentRank` / `DS4.TalentRank` (etc.) exist in the lang files. No blockers from me. Once this is undrafted, it looks mergeable.

Athemis added 1 commit

2026-02-06 07:25:23 +00:00

Merge branch 'main' into feat/talents-for-humanoid-creatures

ci/woodpecker/pr/checks Pipeline was successful

Details

314a1c5e69