refactor(actor): introduce shared action effect runtime service #107

Merged

Athemis merged 9 commits from feature/spell-talent-automation into main 2026-03-06 16:08:11 +00:00

Conversation 0 Commits 9 Files changed 8 +876 -125

Athemis commented 2026-03-06 15:39:40 +00:00

Owner

Copy link

Summary

This PR delivers the first implementation phase for talent/spell automation groundwork:

• adds a shared ActionEffectService runtime contract for target resolution, formula resolution, and effect execution
• introduces a shared runtime model builder (buildActionEffectRuntimeModel)
• routes consume-flow effect execution through the service object
• keeps existing consume user-facing behavior stable (chat roll transparency, active effect application, and item consumption flow)
• strengthens characterization and service contract coverage

What this PR does not do

• no direct automation rollout for new talents/spells yet
• no content pack migration for talent/spell entries yet

Testing

• pnpm test
• targeted regression checks around consume-flow and action-effect service

Related

• #104
• #105
• #90

## Summary This PR delivers the first implementation phase for talent/spell automation groundwork: - adds a shared ActionEffectService runtime contract for target resolution, formula resolution, and effect execution - introduces a shared runtime model builder (buildActionEffectRuntimeModel) - routes consume-flow effect execution through the service object - keeps existing consume user-facing behavior stable (chat roll transparency, active effect application, and item consumption flow) - strengthens characterization and service contract coverage ## What this PR does not do - no direct automation rollout for new talents/spells yet - no content pack migration for talent/spell entries yet ## Testing - pnpm test - targeted regression checks around consume-flow and action-effect service ## Related - #104 - #105 - #90

Athemis added 8 commits 2026-03-06 15:39:40 +00:00

test(consume): add characterization coverage before service refactor 1df78d2494

test(consume): harden characterization assertions a67a0bc006

test(actor): define ActionEffectService contract 71968212d7

feat(actor): implement ActionEffectService execution contract 1fefdf8b7e

refactor(actor): complete action effect runtime execution a33e642fb1

refactor(actor): route consume flow through action effect runtime c03198bb63

fix(actor): preserve consume runtime behavior in service flow c3ccd2c835

test(actor): document action effect resolver and heal guard 55c8e68014

Athemis referenced this pull request 2026-03-06 15:40:06 +00:00

Automation backlog: non-defensive and healing spells #104

Athemis referenced this pull request 2026-03-06 15:40:06 +00:00

Automation backlog: active talent effects #105

Athemis referenced this pull request 2026-03-06 15:40:07 +00:00

Complex consumables: spell-like and special resolution #90

Athemis force-pushed feature/spell-talent-automation from 55c8e68014 to c92d5171de 2026-03-06 15:43:13 +00:00 Compare

Athemis added 1 commit 2026-03-06 16:07:11 +00:00

docs(readme): document consume effect runtime architecture ad6d1d1286

Athemis self-assigned this 2026-03-06 16:07:48 +00:00

Athemis added the

enhancement

label 2026-03-06 16:07:58 +00:00

Athemis added this to the 3.3.0 milestone 2026-03-06 16:08:01 +00:00

Athemis merged commit a1d0fe5997 into main 2026-03-06 16:08:11 +00:00

Athemis deleted branch feature/spell-talent-automation 2026-03-06 16:08:11 +00:00

Athemis referenced this pull request from a commit 2026-03-06 16:08:13 +00:00

Merge pull request 'refactor(actor): introduce shared action effect runtime service' (#107) from feature/spell-talent-automation into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

technical-debt

Technical improvements needed to maintain code quality and future compatibility

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

question

technical-debt

wontfix

Milestone

Clear milestone

No items

No milestone

3.3.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

Athemis

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Athemis/ds4!107

No description provided.